HIP backend #30
Merged
HIP backend #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR contains a workaround for #28. |
Co-authored-by: kswirydo <kasia.swirydowicz@gmail.com>
pelesh
force-pushed
the
hip-first-take-dev
branch
from
dff46da
to
3b1b782
Compare
|
Merged @kswirydo's implementation of matrix and vector kernels and rebased to |
* Fix warnings in HIP branch.
* Use enums for memory space ID in matrix classes. * Use enums for vector class memory space IDs.
* Add first pass CMake cleanup - need to fix include_directories and add custom library macro. * Fix find HIP cmake function. * Update CMakePresets.json Co-authored-by: Nicholson Koukpaizan <72402802+nkoukpaizan@users.noreply.github.com> --------- Co-authored-by: rcrutherford <robert.rutherford@pnnl.gov> Co-authored-by: Nicholson Koukpaizan <72402802+nkoukpaizan@users.noreply.github.com>
* rocsolver class * rocsolver-rf functionality test runs * rocsolver EXAMPLE * Cleanup before exiting examples and avoid double delete. (#49) * Enable HIP support in Gramm-Schmidt and FGMRES (#50) * Enable HIP in GS and FGMRES * Do not build FGMRES without GPU. --------- Co-authored-by: kswirydo <kasia.swirydowicz@gmail.com> --------- Co-authored-by: kswirydo <kasia.swirydowicz@gmail.com>
* a WORKING alternative triangular solver (faster) for rocsolverrf --------- Co-authored-by: kswirydo <kasia.swirydowicz@gmail.com>
pelesh
requested review from
rothpc and
cameronrutherford
and removed request for
maksud
Co-authored-by: kswirydo <kasia.swirydowicz@gmail.com>
* Add working incline build * Update spack submodule with rocsolver. * Update spack and add rocsolver/roctracer to CMake. * Remove several blanket include_directories. * Fix exported CMake bug in CXX_STANDARD * Update examples/resolve_consumer/CMakeLists.txt --------- Co-authored-by: Ryan Danehy <dane678@deception01.pnl.gov> Co-authored-by: pelesh <peless@ornl.gov>
kswirydo
approved these changes
Nov 3, 2023
This was referenced Nov 3, 2023
This was referenced Nov 3, 2023
This was referenced Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pre-hackathon PR with purpose to track multiple issues and code preparation for the event. So far, this includes:
CC @rothpc @cameronrutherford @jaelynlitz @ryandanehy @nkoukpaizan